"Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> And remove the convoluted use of qmp_migrate_set_capabilities() to >> enable disable MIGRATION_CAPABILITY_BLOCK. >> >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> --- >> migration/migration.c | 34 ++++++++++++++++------------------ >> 1 file changed, 16 insertions(+), 18 deletions(-) >> >> diff --git a/migration/migration.c b/migration/migration.c >> index 119027a656..e3062530f0 100644 >> --- a/migration/migration.c >> +++ b/migration/migration.c >> @@ -1910,25 +1910,24 @@ void migrate_set_state(int *state, int old_state, >> int new_state) >> } >> } >> >> -static MigrationCapabilityStatus *migrate_cap_add(MigrationCapability index, >> - bool state) >> +static bool migrate_cap_set(int cap, bool value, Error **errp) > > Why int cap rather than MigrationCapability ?
It is the index in one array, so it is int. And it is much, much shorter. In this particular case I think that we don't lost anything having it as int, but will not fight over this O:-) Later, Juan.
