Re: [PATCH 2/2] hw/nvme: fix memory leak in nvme_dsm

[Philippe Mathieu-Daudé]

On 11/4/23 21:04, Klaus Jensen wrote:

From: Klaus Jensen <k.jen...@samsung.com>

The iocb (and the allocated memory to hold LBA ranges) leaks if reading
the LBA ranges fails.

Fix this by adding a free and an unref of the iocb.

Reported-by: Coverity (CID 1508281)
Fixes: d7d1474fd85d ("hw/nvme: reimplement dsm to allow cancellation")
Signed-off-by: Klaus Jensen <k.jen...@samsung.com>
---
  hw/nvme/ctrl.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 8b7be1420912..ac24eeb5ed5a 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -2619,6 +2619,9 @@ static uint16_t nvme_dsm(NvmeCtrl *n, NvmeRequest *req)
          status = nvme_h2c(n, (uint8_t *)iocb->range, sizeof(NvmeDsmRange) * 
nr,
                            req);
          if (status) {
+            g_free(iocb->range);
+            qemu_aio_unref(iocb);

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

I note the qemu_aio_FOO() functions are not documented.

+
              return status;
          }