Re: [PATCH] pcie: Release references of virtual functions

[Cédric Le Goater]

On 4/11/23 11:04, Akihiko Odaki wrote:

pci_new() automatically retains a reference to a virtual function when
registering it so we need to release the reference when unregistering.

Fixes: 7c0fa8dff8 ("pcie: Add support for Single Root I/O Virtualization 
(SR/IOV)")
Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com>

Reviewed-by: Cédric Le Goater <c...@kaod.org>

---
  hw/pci/pcie_sriov.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c
index aa5a757b11..76a3b6917e 100644
--- a/hw/pci/pcie_sriov.c
+++ b/hw/pci/pcie_sriov.c
@@ -211,6 +211,7 @@ static void unregister_vfs(PCIDevice *dev)
              error_free(local_err);
          }
          object_unparent(OBJECT(vf));
+        object_unref(OBJECT(vf));
      }
      g_free(dev->exp.sriov_pf.vf);
      dev->exp.sriov_pf.vf = NULL;