On Sat, 1 Apr 2023 at 05:52, Richard Henderson <richard.hender...@linaro.org> wrote: > > Assign pc and use store_release to assign tb. > > Fixes: 2dd5b7a1b91 ("accel/tcg: Move jmp-cache `CF_PCREL` checks to caller") > Reported-by: Weiwei Li <liwei...@iscas.ac.cn> > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > accel/tcg/cpu-exec.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-)
I don't fully understand the code here, but before 2dd5b7a1b91 this was a callsite for tb_jmp_cache_set(), 2dd5b7a1b91 expanded out the call but forgot the CF_PCREL half of the if, and this patch restores it. Which all seems logical, so Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM