On Wed, Mar 29, 2023, 4:00 PM Daniel P. Berrangé <berra...@redhat.com>
wrote:
> On Wed, Mar 29, 2023 at 03:55:13PM +0200, Andreas Schwab wrote:
> > Do not reverse the order of environment variables in the target environ
> > array relative to the incoming environ order. Some testsuites depend on
> a
> > specific order, even though it is not defined by any standard.
> >
> > Signed-off-by: Andreas Schwab <sch...@suse.de>
> > ---
> > linux-user/main.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
>
> bsd-user/main.c appears to have an identical code pattern that
> will need the same fix
>
Agreed. I am finishing up a vacation but was going to check on this... I
agree that bsd-user wants to do this too...
Warner
>
> > diff --git a/linux-user/main.c b/linux-user/main.c
> > index 4b18461969..dbfd3ee8f1 100644
> > --- a/linux-user/main.c
> > +++ b/linux-user/main.c
> > @@ -691,7 +691,13 @@ int main(int argc, char **argv, char **envp)
> > envlist = envlist_create();
> >
> > /* add current environment into the list */
> > + /* envlist_setenv adds to the front of the list; to preserve environ
> > + order add from back to front */
> > for (wrk = environ; *wrk != NULL; wrk++) {
> > + continue;
> > + }
> > + while (wrk != environ) {
> > + wrk--;
> > (void) envlist_setenv(envlist, *wrk);
> > }
> >
> > --
> > 2.40.0
> >
> >
> > --
> > Andreas Schwab, SUSE Labs, sch...@suse.de
> > GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
> > "And now for something completely different."
> >
>
> With regards,
> Daniel
> --
> |: https://berrange.com -o-
> https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o-
> https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o-
> https://www.instagram.com/dberrange :|
>
>
>
