On 3/28/23 06:30, Philippe Mathieu-Daudé wrote:
diff --git a/target/arm/internals.h b/target/arm/internals.h
index 673519a24a..a617466fa8 100644
--- a/target/arm/internals.h
+++ b/target/arm/internals.h
@@ -1389,6 +1389,14 @@ int exception_target_el(CPUARMState *env);
  bool arm_singlestep_active(CPUARMState *env);
  bool arm_generate_debug_exceptions(CPUARMState *env);
+static inline uint64_t pauth_param_mask(ARMVAParameters param)

Perhaps pauth_ptr_mask_param, or just pauth_ptr_mask (see below).

+static inline uint64_t pauth_ptr_mask(CPUARMState *env, uint64_t ptr, bool 
data)
+{
+    ARMMMUIdx mmu_idx = arm_stage1_mmu_idx(env);
+    ARMVAParameters param = aa64_va_parameters(env, ptr, mmu_idx, data);
+
+    return pauth_param_mask(param);
+}

This is only used by gdbstub. Just put it there. Perhaps merge it with aarch64_gdb_get_pauth_reg directly, so that we can use the simpler 'pauth_ptr_mask' name above.


Either way,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~

Reply via email to