On Thu, Mar 16, 2023 at 08:13:22AM +0100, Markus Armbruster wrote: > Union TestIfUnion is conditional on macros TEST_IF_UNION and > TEST_IF_STRUCT. It uses TestIfEnum, which is conditional on macro > TEST_IF_ENUM. If TEST_IF_ENUM and TEST_IF_STRUCT are defined, but > TEST_IF_ENUM isn't, the generated code won't compile.
s/ENUM/UNION/ in one of these two uses in this sentence. > > Command test-if-cmd is conditional an macros TEST_IF_CMD and > TEST_IF_STRUCT, and uses TestIfEnum. Similar issue. > > Event TEST_IF_EVENT is conditional an macros TEST_IF_EVT and > TEST_IF_STRUCT, and uses TestIfEnum. Similar issue. > > Replace the uses of TestIfEnum in the latter two by str. > > TestIfUnion is now TestIfEnum's only user. Change TestIfEnum's > condition to TEST_IF_UNION. Fair enough, once the commit message doesn't confuse me in the first paragraph ;) > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > tests/qapi-schema/qapi-schema-test.json | 6 +++--- > tests/qapi-schema/qapi-schema-test.out | 8 +++----- > 2 files changed, 6 insertions(+), 8 deletions(-) > Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
