On Thu, Mar 16, 2023 at 08:13:20AM +0100, Markus Armbruster wrote: > A union's 'discriminator' must name a one of the common members.
s/ a// > QAPISchemaVariants.check() looks it up by its c_name(), then checks > the name matches exactly (because c_name() is not injective). > > Tests union-base-empty and union-invalid-discriminator both cover the > case where lookup fails. Repurpose the latter to cover the case where > it succeeds and the name check fails. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > tests/qapi-schema/union-invalid-discriminator.err | 2 +- > tests/qapi-schema/union-invalid-discriminator.json | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Eric Blake <ebl...@redhat.com> (- vs. _ is subtle, especially since I purposefully case-map them to one another whenever I can...) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
