Laszlo Ersek <ler...@redhat.com> writes: > The lockf() call in qemu_create_pidfile() aims at ensuring mutual > exclusion. We shouldn't close the pidfile on success, because that drops > the lock as well [1]: > > "File locks shall be released on first close by the locking process > of any file descriptor for the file." > > Coverity may complain again about the leaked file descriptor; let's > worry about that later. > > [1] http://pubs.opengroup.org/onlinepubs/9699919799/functions/lockf.html
Broken in commit 1bbd1592 by yours truly %-} Suitable pointer could be added to the commit message. > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > Please keep me CC'd, I'm not subscribed. Thanks! > > os-posix.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/os-posix.c b/os-posix.c > index 5c437ca..f4940c8 100644 > --- a/os-posix.c > +++ b/os-posix.c > @@ -348,6 +348,5 @@ int qemu_create_pidfile(const char *filename) > return -1; > } > > - close(fd); > return 0; > } We intentionally leak fd here. A comment would be nice. Reviewed-by: Markus Armbruster <arm...@redhat.com>
