On Fri, Mar 3, 2023 at 9:29 AM Daniel P. Berrangé <berra...@redhat.com> wrote: > > On Fri, Mar 03, 2023 at 09:24:16AM -0800, Haitao Shan wrote: > > On Fri, Mar 3, 2023 at 2:19 AM Philippe Mathieu-Daudé <phi...@linaro.org> > > wrote: > > > > > > On 3/3/23 08:33, Michael S. Tsirkin wrote: > > > > On Thu, Mar 02, 2023 at 06:26:12PM -0800, Haitao Shan wrote: > > > >> Add the configure support for the Android Emulator hypervisor driver > > > >> accelerator. The Android Emulator hypervisor driver is a Windows > > > >> driver made by porting the KVM from kernel 4.9-rc7. > > > >> > > > >> Signed-off-by: Haitao Shan <hs...@google.com> > > > > > > > > Replying on patch 1 but it applies to the whole patchset. > > > > > > Indeed this series lacks a cover letter, which would show > > > this huge diffstat: > > Sorry. I think I made a mistake and I know being new to > > the community is not an excuse. I will correct it in future. > > I don't know if "git sendmail" can have a cover letter. So the > > cover letter was written separately. Again, I am sorry for > > that. > > FWIW, I can recommend using the 'git-publish'[1] tool instead > of git sendemail. git-publish helps to just "do the right > thing" without you needing to know the details. It will prompt > for a cover letter to be entered, include the diffstat, and > CC any maintainers related to files your patch touches. It > figures this all our from the .gitpublish file that is in the > root of the QEMU git repo. > > If you want test send some mails, then just tell git-publsh to > send to yourself instead of qemu-devel. Got it. Thank you very much for your advice. I am going to do the experiment now.
> > With regards, > Daniel > > [1] https://github.com/stefanha/git-publish > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| > -- Haitao @Google
