On Thu, 23 Feb 2023 at 20:47, Richard Henderson
<richard.hender...@linaro.org> wrote:
>
> While changes are made to prot within tlb_set_page_full, they are
> an implementation detail of softmmu. Retain the original for any
> target use of probe_access_full.
>
> Fixes: 4047368938f6 ("accel/tcg: Introduce tlb_set_page_full")
> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
> ---
> accel/tcg/cputlb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
> index d7ca90e3b4..169adc0262 100644
> --- a/accel/tcg/cputlb.c
> +++ b/accel/tcg/cputlb.c
> @@ -1251,7 +1251,6 @@ void tlb_set_page_full(CPUState *cpu, int mmu_idx,
> desc->fulltlb[index] = *full;
> desc->fulltlb[index].xlat_section = iotlb - vaddr_page;
> desc->fulltlb[index].phys_addr = paddr_page;
> - desc->fulltlb[index].prot = prot;
>
> /* Now calculate the new entry */
> tn.addend = addend - vaddr_page;
> --
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
thanks
-- PMM
