On Thu, Mar 02, 2023 at 07:58:28AM +0100, Markus Armbruster wrote: > Marc-André Lureau <marcandre.lur...@gmail.com> writes: > > > Hi > > > > On Wed, Mar 1, 2023 at 5:16 PM Markus Armbruster <arm...@redhat.com> wrote: > >> What about 3. have an additional command conditional on CONFIG_WIN32? > >> Existing getfd stays the same: always fails when QEMU runs on a Windows > >> host. The new command exists only when QEMU runs on a Windows host. > > We could additionally deprecate getfd for Windows. > > > This is what was suggested initially: > > https://patchew.org/QEMU/20230103110814.3726795-1-marcandre.lur...@redhat.com/20230103110814.3726795-9-marcandre.lur...@redhat.com/ > > > > I also like it better, as a specific command for windows sockets, less > > ways to use it wrongly. > > Daniel, what do you think?
I wasn't especially a fan of platform specific APIs, but perhaps in retrospect it will be the lesser of two evils. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
