On Thu, Mar 02, 2023 at 11:28:44AM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 02.03.23 00:09, Michael S. Tsirkin wrote: > > On Thu, Feb 16, 2023 at 09:03:51PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > To be used in further patch to identify the device hot-plugged into > > > pcie-root-port. > > > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy<vsement...@yandex-team.ru> > > > Reviewed-by: Anton Kuchin<antonkuc...@yandex-team.ru> > > Wait a second does this work for multifunction devices correctly? > > > > I thought about that and I'm just lost:) > > Could several (multifunction?) devices be plugged into one pcie-root-port > device?
One device per port but one multifunction device is represented as multiple PCIDevice structures. > Same question for SHPC slots. For example, shpc_free_devices_in_slot() looks > like we can have several devices in one slot.. > On the other hand, in shpc_reset() we have construction > shpc->sec_bus->devices[PCI_DEVFN(SHPC_IDX_TO_PCI(i), 0)] to access the device > in slot. The only one device. > > -- > Best regards, > Vladimir Same thing. ... and let's not get started about sriov and ari ... -- MST
