On Thu, Mar 2, 2023 at 7:43 AM Palmer Dabbelt <pal...@dabbelt.com> wrote: > > On Wed, 01 Mar 2023 01:55:34 PST (-0800), Bin Meng wrote: > > On Wed, Mar 1, 2023 at 5:52 PM LIU Zhiwei <zhiwei_...@linux.alibaba.com> > > wrote: > >> > >> > >> On 2023/2/28 18:40, Bin Meng wrote: > >> > There is no need to generate the CSR XML if the Zicsr extension > >> > is not enabled. > >> > >> Should we generate the FPU XML or Vector XML when Zicsr is not enabled? > > > > Good point. I think we should disable that too. > > Seems reasonable. Did you want to do that as part of a v3, or just as a > follow-on fix? >
I looked at this further. The FPU / Vector XML is guarded by the " env->misa_ext" check. If Zicsr is disabled while F or V extension is off, QEMU will error out in riscv_cpu_realize() earlier before the gdbstub init. So current patch should be fine. Regards, Bin
