On 2012-01-12 19:37, Andreas Färber wrote: > Am 08.01.2012 17:31, schrieb Andreas Färber: >> Am 08.01.2012 13:01, schrieb Gerhard Wiesinger: >>> On Wed, 4 Jan 2012, Gerhard Wiesinger wrote: >>> >>>> Testscenario: >>>> 1.) Boot e.g. OS with VMMouse support (e.g. Windows) >>>> 2.) reboot >>>> 3.) Boot e.g. OS without VMMouse support (e.g. DOS) => PS/2 mouse >>>> doesn't work any more. Fixes that issue. >>>> >>>> Reason is that VMMouse has priority and disables all other mouse >>>> entities and therefore must be disabled on reset. >>> >>> Any further comments before integrating the patch? >> >> I implicitly asked you for a more verbose commit message. >> >> For example, based on the info you provided as a reply above: >> >> --8<-- >> hw/vmmouse.c: Disable vmmouse on reboot >> >> When a guest activated the vmmouse, following a reboot the vmmouse >> stayed enabled and the PS/2 mouse was unusable. That way, when rebooting >> to guests without vmmouse support the mouse would not work. >> >> Fix this by disabling the vmmouse in its reset handler. >> --8<-- > > I have been unable to reproduce this issue with our qemu-kvm 0.15.1. > SLES 11 uses vmmouse, whereas SLES installation does not use vmmouse. > After doing a kdump or reboot in SLES, the mouse worked just fine in > either of them.
I can confirm the that this patch fixes a real issue. Setup: qemu.git, opensuse 11.4 guest, SDL graphic, system_reset while guest is using the vmmouse. Without the patch, the vmmouse become unusable after the reboot. Also, the mouse stays in absolute mode even before X starts again. So please merge. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
