On 20 January 2012 20:47, Mark Langsdorf <mark.langsd...@calxeda.com> wrote:
> + /* highbank requires a dtb in order to boot, and the dtb will override
> + * the board ID. The following value is ignored, so set it to -1 to be
> + * clear that the value is meaningless.
> + */
> + highbank_binfo.board_id = 0;
Code disagrees with comment :-)
> +static QEMUMachine highbank_machine = {
> + .name = "highbank",
> + .desc = "Calxeda Highbank (ECX-1000)",
> + .init = highbank_init,
> + .use_scsi = 1,
> + .max_cpus = 4,
> + .no_vga = 1,
> +};
Unfortunately commit a369da5f3 just landed on master and this doesn't
compile any more. I think you should be able to just drop the ".no_vga = 1"
line.
Otherwise OK.
-- PMM
