Re: [PATCH v3 3/4] qga/vss-win32: fix warning for clang++-15

[Pierrick Bouvier]

Reviewed-by: Konstantin Kostiuk <kkost...@redhat.com>

On 2/20/23 12:12, Pierrick Bouvier wrote:

Reported when compiling with clang-windows-arm64.

../qga/vss-win32/install.cpp:537:9: error: variable 'hr' is used uninitialized 
whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
     if (!(ControlService(service, SERVICE_CONTROL_STOP, NULL))) {
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../qga/vss-win32/install.cpp:545:12: note: uninitialized use occurs here
     return hr;
            ^~
Signed-off-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
---
  qga/vss-win32/install.cpp | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
index b57508fbe0..b8087e5baa 100644
--- a/qga/vss-win32/install.cpp
+++ b/qga/vss-win32/install.cpp
@@ -518,7 +518,7 @@ namespace _com_util
  /* Stop QGA VSS provider service using Winsvc API  */
  STDAPI StopService(void)
  {
-    HRESULT hr;
+    HRESULT hr = S_OK;
      SC_HANDLE manager = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
      SC_HANDLE service = NULL;