Cc'ing Paolo/Daniel/Thomas

On 7/2/23 15:52, Matheus Tavares Bernardino wrote:
Hexagon's idef-parser machinery uses some bison features that are not
available at older versions. The most preeminent example (as it can
be used as a sentinel) is "%define parse.error verbose". This was
introduced in version 3.0 of the tool, which is able to compile
qemu-hexagon just fine. However, compilation fails with the previous
minor bison release, v2.7. So let's assert the minimum version at
meson.build to give a more comprehensive error message for those trying
to compile QEMU.

[1]: 
https://www.gnu.org/software/bison/manual/html_node/_0025define-Summary.html#index-_0025define-parse_002eerror

Signed-off-by: Matheus Tavares Bernardino <quic_mathb...@quicinc.com>
---
  target/hexagon/meson.build | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/hexagon/meson.build b/target/hexagon/meson.build
index c9d31d095c..42b03c81e6 100644
--- a/target/hexagon/meson.build
+++ b/target/hexagon/meson.build
@@ -183,7 +183,7 @@ if idef_parser_enabled and 'hexagon-linux-user' in 
target_dirs
      )
bison = generator(
-        find_program('bison'),
+        find_program('bison', version: '>=3.0'),
          output: ['@BASENAME@.tab.c', '@BASENAME@.tab.h'],
          arguments: ['@INPUT@', '--defines=@OUTPUT1@', '--output=@OUTPUT0@']
      )


Reply via email to