Re: [PATCH 4/4] pcie: add trace-point for power indicator transitions

[Philippe Mathieu-Daudé]

On 4/2/23 18:47, Vladimir Sementsov-Ogievskiy wrote:

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru>
---
  hw/pci/pcie.c       | 20 ++++++++++++++++++++
  hw/pci/trace-events |  3 +++
  2 files changed, 23 insertions(+)

+static const char *pcie_sltctl_pic_str(uint16_t sltctl)
+{
+    switch (sltctl & PCI_EXP_SLTCTL_PIC) {
+    case PCI_EXP_SLTCTL_PWR_IND_ON:
+        return "on";
+    case PCI_EXP_SLTCTL_PWR_IND_BLINK:
+        return "blink";
+    case PCI_EXP_SLTCTL_PWR_IND_OFF:
+        return "off";
+    default:
+        return "?";

Maybe "illegal"?

Otherwise:

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

+    }
+}