On Thu, Feb 02, 2023 at 09:15:23PM +0300, Andrey Zhadchenko via wrote:
> The last return statement should return true, as we already evaluated that
> start == next_dirty
>
> Also, fix hbitmap_status() description in header
>
> Cc: qemu-sta...@nongnu.org
> Fixes: a6426475a75 ("block/dirty-bitmap: introduce
> bdrv_dirty_bitmap_status()")
> Signed-off-by: Andrey Zhadchenko <andrey.zhadche...@virtuozzo.com>
> ---
> include/qemu/hbitmap.h | 2 +-
> util/hbitmap.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Eww, nasty bug; looks like copy-before-write is the only curernt
client of this interface.
Reviewed-by: Eric Blake <ebl...@redhat.com>
Is there any way to enhance an iotest to add coverage for this code?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
