Hi,
I was running check-tcg with ASan enabled on master, and ran into
the following use-after-free. There appears to be a race between
jump cache invalidation and thread destruction (?)
I thought I'd post here since I noticed some previous discussion on the
topic, and I'm not sure myself what a proper fix would look like.
Tested on arm/aarch64/x86_64-linux-user.
Here's a snippet of the ASan output:
=================================================================
==187529==ERROR: AddressSanitizer: heap-use-after-free on address
0x62d000f433b0 at pc 0x55cfefe00246 bp 0x7f4725f400b0 sp 0x7f4725f400a0
READ of size 8 at 0x62d000f433b0 thread T2
#0 0x55cfefe00245 in tb_jmp_cache_inval_tb
/home/aj/git/qemu-upstream/build/../accel/tcg/tb-maint.c:861
#1 0x55cfefe00245 in do_tb_phys_invalidate
/home/aj/git/qemu-upstream/build/../accel/tcg/tb-maint.c:900
#2 0x55cfefe0088a in tb_phys_invalidate__locked
/home/aj/git/qemu-upstream/build/../accel/tcg/tb-maint.c:916
#3 0x55cfefe0088a in tb_invalidate_phys_range
/home/aj/git/qemu-upstream/build/../accel/tcg/tb-maint.c:1000
#4 0x55cfefe7ecf9 in target_munmap
/home/aj/git/qemu-upstream/build/../linux-user/mmap.c:766
#5 0x55cfefea5815 in do_syscall1
/home/aj/git/qemu-upstream/build/../linux-user/syscall.c:10105
#6 0x55cfefe9c950 in do_syscall
/home/aj/git/qemu-upstream/build/../linux-user/syscall.c:13329
#7 0x55cfefb97255 in cpu_loop
../linux-user/x86_64/../i386/cpu_loop.c:233
#8 0x55cfefec7af4 in clone_func
/home/aj/git/qemu-upstream/build/../linux-user/syscall.c:6633
#9 0x7f4726bbb8fc (/usr/lib/libc.so.6+0x868fc)
#10 0x7f4726c3da5f (/usr/lib/libc.so.6+0x108a5f)
0x62d000f433b0 is located 28592 bytes inside of 32768-byte region
[0x62d000f3c400,0x62d000f44400)
freed by thread T387 here:
#0 0x7f47270be672 in __interceptor_free
/usr/src/debug/gcc/libsanitizer/asan/asan_malloc_linux.cpp:52
#1 0x55cfefd071b8 in cpu_exec_unrealizefn
/home/aj/git/qemu-upstream/build/../cpu.c:180
#2 0x55cfefeea287 in property_set_bool
/home/aj/git/qemu-upstream/build/../qom/object.c:2285
#3 0x55cfefee603b in object_property_set
/home/aj/git/qemu-upstream/build/../qom/object.c:1420
#4 0x55cfefeef21c in object_property_set_qobject
/home/aj/git/qemu-upstream/build/../qom/qom-qobject.c:28
previously allocated by thread T0 here:
#0 0x7f47270bf411 in __interceptor_calloc
/usr/src/debug/gcc/libsanitizer/asan/asan_malloc_linux.cpp:77
#1 0x7f4726e77681 in g_malloc0 (/usr/lib/libglib-2.0.so.0+0x53681)
#2 0x55cfefed7cfe in device_set_realized
/home/aj/git/qemu-upstream/build/../hw/core/qdev.c:510
#3 0x55cfefeea287 in property_set_bool
/home/aj/git/qemu-upstream/build/../qom/object.c:2285
#4 0x55cfefee603b in object_property_set
/home/aj/git/qemu-upstream/build/../qom/object.c:1420
#5 0x55cfefeef21c in object_property_set_qobject
/home/aj/git/qemu-upstream/build/../qom/qom-qobject.c:28
--
Anton Johansson,
rev.ng Labs Srl.
