On 2/1/23 05:04, Philippe Mathieu-Daudé wrote:
On 30/1/23 22:48, Richard Henderson wrote:
Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
Message-Id: <20221112042555.2622152-3-richard.hender...@linaro.org>
---
target/arm/helper-a64.h | 2 --
target/arm/helper-a64.c | 43 ---------------------------
target/arm/translate-a64.c | 61 +++++++++++---------------------------
3 files changed, 18 insertions(+), 88 deletions(-)
Is it worth extract this pattern:
+ if (s->be_data == MO_LE) {
+ tcg_gen_concat_i64_i128(val, t1, t2);
+ } else {
+ tcg_gen_concat_i64_i128(val, t2, t1);
+ }
as a helper for readability ?
It hasn't come up often so far.
How would you imagine that would look?
r~
