On Sat, Jan 28, 2023 at 06:15:03AM -0500, Michael S. Tsirkin wrote: > On Mon, Jan 23, 2023 at 06:37:21AM -0600, Jason A. Donenfeld wrote: > > On Mon, Jan 23, 2023 at 6:12 AM Michael S. Tsirkin <m...@redhat.com> wrote: > > > > > > On Sun, Jan 22, 2023 at 08:21:30PM -0800, Eric Biggers wrote: > > > > Hi Michael, > > > > > > > > On Tue, Jan 10, 2023 at 12:50:42PM -0500, Michael S. Tsirkin wrote: > > > > > On Tue, Jan 10, 2023 at 04:34:49PM +0100, Jason A. Donenfeld wrote: > > > > > > Hi Michael, > > > > > > > > > > > > Could you queue up this patch and mark it as a fix for 7.2.1? It is > > > > > > a > > > > > > straight-up bug fix for a 7.2 regression that's now affected several > > > > > > users. > > > > > > > > > > OK. In the future pls cc me if you want me to merge a patch. Thanks! > > > > > > > > > > > - It has two Tested-by tags on the thread. > > > > > > - hpa, the maintainer of the kernel side of this, confirmed on one > > > > > > of > > > > > > the various tributary threads that this approach is a correct one. > > > > > > - It doesn't introduce any new functionality. > > > > > > > > > > > > For your convenience, you can grab this out of lore here: > > > > > > > > > > > > > > > > > > https://lore.kernel.org/lkml/20221230220725.618763-1-ja...@zx2c4.com/ > > > > > > > > > > > > Or if you want to yolo it: > > > > > > > > > > > > curl > > > > > > https://lore.kernel.org/lkml/20221230220725.618763-1-ja...@zx2c4.com/raw > > > > > > | git am -s > > > > > > > > > > > > It's now sat silent on the mailing list for a while. So let's > > > > > > please get > > > > > > this committed and backported so that the bug reports stop coming > > > > > > in. > > > > > > > > > > > > > > This patch still isn't on QEMU's master branch. What happened to it? > > > > > > > > - Eric > > > > > > Indeed though I remember picking it up. Tagged again now. Thanks! > > > > Thanks. What branch is this in? I didn't see it on: > > https://gitlab.com/mstredhat/qemu/-/branches/active > > https://github.com/mstsirkin/qemu/branches > > I don't use github really. And it was not pushed to gitlab as I was > figuring out issues with other patches before starting CI as CI minutes > are limited.
QEMU CI config as of a few months ago, pushing to gitlab will *not* start CI pipelines. You need to explicitly use opt-in to it when pushing by using 'git push -o ci.variable=QEMU_CI=1' to create a pipeline with all jobs manual or QEMU_CI=2 to create a pipeline and immediately run all jobs. Alternatively use the web UI to start the pipeline, again setting QEMU_CI=1|2 So don't let CI minutes concerns dissuade from pushing to gitlab merely to publish the code. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
