Markus Armbruster <arm...@redhat.com> wrote: > "Dr. David Alan Gilbert" <dgilb...@redhat.com> writes: > >> * Markus Armbruster (arm...@redhat.com) wrote: >>> "Dr. David Alan Gilbert" <dgilb...@redhat.com> writes: >>> >>> > * Markus Armbruster (arm...@redhat.com) wrote: >>> >> Clean up includes so that osdep.h is included first and headers >>> >> which it implies are not included manually. >>> > >>> > That change doesn't seem to match the message; the patch is removing the >>> > osdep.h include. >>> >>> It's the commit message scripts/clean-includes creates :) >>> >>> I can throw in another patch to the script so it mentions it also >>> removes qemu/osdep.h from headers. >> >> Oh hmm it would be clearer; > > What about > > $GITSUBJ: Clean up includes > > Clean up includes so that osdep.h is included first in .c and not in > .h, and headers which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > >> but OK then, so >> >> Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
Sounds ok to me. Reviewed-by: Juan Quintela <quint...@redhat.com>
