Philippe Mathieu-Daudé <phi...@linaro.org> writes: > On 19/1/23 12:41, Markus Armbruster wrote: >> Philippe Mathieu-Daudé <phi...@linaro.org> writes: >> >>> On 19/1/23 07:59, Markus Armbruster wrote: >>>> This commit was created with scripts/clean-includes. >>>> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> [...] >> >>> Up to here: >>> >>> Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org> >>> >>>> diff --git a/util/async-teardown.c b/util/async-teardown.c >>>> index 62bfce1b3c..62cdeb0f20 100644 >>>> --- a/util/async-teardown.c >>>> +++ b/util/async-teardown.c >>>> @@ -10,16 +10,12 @@ >>>> * option) any later version. See the COPYING file in the top-level >>>> directory. >>>> * >>>> */ >>>> -#include <stdlib.h> >>>> -#include <stdio.h> >>>> -#include <sys/types.h> >>>> -#include <dirent.h> >>>> -#include <sys/prctl.h> >>>> -#include <signal.h> >>>> -#include <sched.h> >>>> -#include <unistd.h> >>>> #include "qemu/osdep.h" >>>> +#include <dirent.h> >>>> +#include <sys/prctl.h> >>>> +#include <sched.h> >>>> + >>>> #include "qemu/async-teardown.h" >>> >>> This file has more changes. >> I'm not sure I understand. >> The patch does two related things: >> 1. It puts qemu/osdep.h first. The diff makes it look like we leave it >> in place and move other stuff across, but that's the same. >> 2. It deletes inclusions of headers qemu/osdep.h already includes: >> <stdlib.h> >> <stdio.h> >> <sys/types.h> >> <signal.h> >> <unistd.h> > > Ah, the other files get this done in the "Drop duplicate #include" patch.
I assume this extends your R-by to the complete patch. Correct me if I'm wrong, please.
