On Wed, Jan 18, 2023 at 09:01:48AM -1000, Richard Henderson wrote: > On 1/17/23 23:33, Philippe Mathieu-Daudé wrote: > > Remove dead code: > > - unused fields in CPUTriCoreState > > - (unexisting) tricore_def_t structure > > - forward declaration of tricore_boot_info structure > > (declared in "hw/tricore/tricore.h", used once in > > hw/tricore/tricore_testboard.c). > > > > Reviewed-by: Richard Henderson<richard.hender...@linaro.org> > > Reviewed-by: Bastian Koppelmann<kbast...@mail.uni-paderborn.de> > > Signed-off-by: Philippe Mathieu-Daudé<phi...@linaro.org> > > --- > > v2: Do not remove 'hflags' in case it used: > > > > https://lore.kernel.org/qemu-devel/20230118090319.32n4uto7ogy3gfr6@schnipp.zuhause/ > > No, remove it, I don't expect it would ever be used.
Agreed, patch v1 is fine. Cheers, Bastian
