On 01/15/2012 10:21 AM, Avi Kivity wrote:
> On 01/13/2012 06:54 PM, Andreas Färber wrote:
>>> +static void megasas_unmap_sgl(struct megasas_cmd_t *cmd)
>>> +{
>>> + int i, is_write = megasas_frame_is_write(cmd);
>>> +
>>> + for (i = 0; i < cmd->iov_cnt; i++) {
>>> + cpu_physical_memory_unmap(cmd->iov[i].iov_base,
>>> cmd->iov[i].iov_len,
>>> + is_write, cmd->iov[i].iov_len);
>>
>> Not sure, but cpu_physical_memory_* sounds old-fashioned. Might need an
>> update to MemoryRegion?
>
> These APIs have not been updated (yet?).
>
That's what I thought.
Plus even virtio is using it, so I'd be very much interested in the
argument why megasas can't use it ...
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
