Ping.
r~
On 1/6/23 09:44, Richard Henderson wrote:
Here's a short-to-medium term alternative to moving all of the ARMCPU
cp_regs hash table to the ARMCPUClass, so that we're no longer leaving
dangling pointers to freed objects encoded in the compiled
TranslationBlocks. (I still think we ought to do less work at
object_{init,realize}, but that may be a much longer term project.)
Instead of giving the helper a direct pointer, pass the cpreg hash key,
which will be constant across cpus. Perform this lookup in the existing
helper_access_check_cp_reg (which had a return value going spare), or a
new helper_lookup_cp_reg. The other cp_regs functions are unchanged,
because they still get a pointer.
This ought to be enough to re-instate Alex's linux-user patch
to free the cpu object after thread termination.
r~
Richard Henderson (2):
target/arm: Reorg do_coproc_insn
target/arm: Look up ARMCPRegInfo at runtime
target/arm/helper.h | 11 +-
target/arm/translate.h | 7 +
target/arm/op_helper.c | 27 ++-
target/arm/translate-a64.c | 49 +++--
target/arm/translate.c | 430 +++++++++++++++++++------------------
5 files changed, 285 insertions(+), 239 deletions(-)
