On Wed, Jan 11, 2023 at 4:44 PM Philippe Mathieu-Daudé <phi...@linaro.org>
wrote:
> Hi Qiang,
>
> On 11/1/23 08:05, Qiang Liu wrote:
> > This patch replaces hw_error to guest error log for [read|write]b
> > accesses when mode_16bit is enabled. This avoids aborting qemu.
> >
> > Fixes: 1248f8d4cbc3 ("hw/lan9118: Add basic 16-bit mode support.")
> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1433
> > Reported-by: Qiang Liu <cyruscy...@gmail.com>
> > Signed-off-by: Qiang Liu <cyruscy...@gmail.com>
> > ---
> > hw/net/lan9118.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/net/lan9118.c b/hw/net/lan9118.c
> > index f1cba55967..7f35715f27 100644
> > --- a/hw/net/lan9118.c
> > +++ b/hw/net/lan9118.c
> > @@ -1209,7 +1209,8 @@ static void lan9118_16bit_mode_write(void *opaque,
> hwaddr offset,
> > return;
> > }
> >
> > - hw_error("lan9118_write: Bad size 0x%x\n", size);
> > + qemu_log_mask(LOG_GUEST_ERROR,
> > + "lan9118_16bit_mode_write: Bad size 0x%x\n", size);
> > }
>
> There are two other uses via BADF(), then we can remove the BADF() macro
> and the "hw/hw.h" inclusion.
I see. Sounds nice! Let me resend the patch.
Best,
Qiang
