On Tue, Jan 10, 2023 at 05:26:55PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > Let's try to reduce our Perl usage during config/build-time. > > Note: this patch might be dropped if "configure: remove > backwards-compatibility code" is merged earlier. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > Tested-by: Thomas Huth <th...@redhat.com> > --- > configure | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/configure b/configure > index 2281892657..9a944698b4 100755 > --- a/configure > +++ b/configure > @@ -2571,11 +2571,9 @@ else > if test -f meson-private/cmd_line.txt; then > # Adjust old command line options whose type was changed > # Avoids having to use "setup --wipe" when Meson is upgraded > - perl -i -ne ' > - s/^gettext = true$/gettext = auto/; > - s/^gettext = false$/gettext = disabled/; > - /^b_staticpic/ && next; > - print;' meson-private/cmd_line.txt > + sed -i.bak -e 's/^gettext = true$/gettext = auto/g' \ > + -e 's/^gettext = false$/gettext = disabled/g' \ > + -e '/^b_staticpic/d' meson-private/cmd_line.txt
Do we really need to have a '.bak' file created ? The original perl cmd didn't With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
