Re: [PATCH v4 15/17] ui: Don't check for mode change after mouse_set error

[Philippe Mathieu-Daudé]

On 9/1/23 20:03, Markus Armbruster wrote:

hmp_mouse_set() doesn't bail out when it can't find a mouse.
Harmless, since qemu_input_check_mode_change() should be a no-op then.
Clean it up anyway.

Signed-off-by: Markus Armbruster <arm...@redhat.com>
---
  ui/input.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/ui/input.c b/ui/input.c
index 8f4a87d1d7..d1c7605238 100644
--- a/ui/input.c
+++ b/ui/input.c
@@ -616,6 +616,7 @@ void hmp_mouse_set(Monitor *mon, const QDict *qdict)

if (!found) {

          error_report("Mouse at index '%d' not found", index);
+        return;

Oops :)

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

      }

qemu_input_check_mode_change();