On Tue, Dec 27, 2022 at 4:54 PM Bin Meng <bm...@tinylab.org> wrote:
>
> Spike machine now supports OpenSBI plain binary bios image, so the
> comments are no longer valid.
>
> Signed-off-by: Bin Meng <bm...@tinylab.org>
Reviewed-by: Alistair Francis <alistair.fran...@wdc.com>
Alistair
> ---
>
> hw/riscv/spike.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c
> index 8606331f61..ab0a945f8b 100644
> --- a/hw/riscv/spike.c
> +++ b/hw/riscv/spike.c
> @@ -256,11 +256,6 @@ static void spike_board_init(MachineState *machine)
> memory_region_add_subregion(system_memory, memmap[SPIKE_MROM].base,
> mask_rom);
>
> - /*
> - * Not like other RISC-V machines that use plain binary bios images,
> - * keeping ELF files here was intentional because BIN files don't work
> - * for the Spike machine as HTIF emulation depends on ELF parsing.
> - */
> if (riscv_is_32bit(&s->soc[0])) {
> firmware_end_addr = riscv_find_and_load_firmware(machine,
> RISCV32_BIOS_BIN,
> memmap[SPIKE_DRAM].base,
> --
> 2.34.1
>
>
