Am 12.01.2012 15:00, schrieb Peter Maydell: > When doing TCG code translation, the target-foo translate.c > code is allowed to bake assumptions into the generated code from > the current values of various fields in the CPUState. This then > imposes the requirement that if the field is changed then tb_flush > must be called to throw away the now-incorrect generated code. > > However, cpu_reset() changes (unsurprisingly) lots of fields in > the CPUState, but it doesn't call tb_flush()... > > So should cpu_reset() implementations be changed to call tb_flush() > as well as tlb_flush(), or is this supposed to work in some other > way?
I would rather suggest to introduce a new cpu_common_reset() that hides these details - memset() for common parts and whatever necessary here. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
