On Fri, Dec 23, 2022 at 6:04 PM Bin Meng <bmeng...@gmail.com> wrote: > > On Thu, Dec 22, 2022 at 2:28 AM Daniel Henrique Barboza > <dbarb...@ventanamicro.com> wrote: > > > > This will make the code more in line with what the other boards are > > doing. We'll also avoid an extra check to machine->kernel_filename since > > we already checked that before executing riscv_load_kernel(). > > > > Signed-off-by: Daniel Henrique Barboza <dbarb...@ventanamicro.com> > > --- > > hw/riscv/spike.c | 31 +++++++++++++++---------------- > > 1 file changed, 15 insertions(+), 16 deletions(-) > > > > Reviewed-by: Bin Meng <bm...@tinylab.org>
This change unfortunately breaks the ELF boot on Spike. I will propose a patch to fix such unexpected dependency. Regards, Bin