Le 22/12/2022 à 18:29, Mauro Matteo Cascella a écrit :
Local variable "name" is allocated through strdup_printf and should be
freed with g_free() to avoid memory leak.

Fixes: 3616f424 ("nubus-device: add romfile property for loading declaration 
ROMs")
Signed-off-by: Mauro Matteo Cascella <mcasc...@redhat.com>
---
  hw/nubus/nubus-device.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/nubus/nubus-device.c b/hw/nubus/nubus-device.c
index 0f1852f671..49008e4938 100644
--- a/hw/nubus/nubus-device.c
+++ b/hw/nubus/nubus-device.c
@@ -80,6 +80,7 @@ static void nubus_device_realize(DeviceState *dev, Error 
**errp)
                                 &error_abort);
          ret = load_image_mr(path, &nd->decl_rom);
          g_free(path);
+        g_free(name);
          if (ret < 0) {
              error_setg(errp, "could not load romfile \"%s\"", nd->romfile);
              return;

Reviewed-by: Laurent Vivier <laur...@vivier.eu>

Reply via email to