On Thu, Jan 12, 2012 at 10:59 AM, Kevin Wolf <kw...@redhat.com> wrote: > Am 06.01.2012 15:01, schrieb Stefan Hajnoczi: >> + buf = qemu_blockalign(bs, STREAM_BUFFER_SIZE); >> + s->common.len = bdrv_getlength(bs); > > No error check?
Will fix. >> + bdrv_get_geometry(bs, (uint64_t *)&end); > > Why call bdrv_getlength() twice? end = s->common.len >> BDRV_SECTOR_BITS > should be the same. Okay, I'll change it. I got sick of BDRV_SECTOR_* and called twice instead.
