> -----Original Message-----
> From: Markus Armbruster <arm...@redhat.com>
> Sent: Monday, December 12, 2022 1:05 AM
> To: qemu-devel@nongnu.org
> Cc: i...@bsdimp.com; kev...@freebsd.org; berra...@redhat.com;
> jonathan.came...@huawei.com; kbast...@mail.uni-paderborn.de;
> jasow...@redhat.com; michael.r...@amd.com; kkost...@redhat.com;
> Taylor Simpson <tsimp...@quicinc.com>; pal...@dabbelt.com;
> alistair.fran...@wdc.com; bin.m...@windriver.com; qemu-
> ri...@nongnu.org
> Subject: [PATCH] include: Don't include qemu/osdep.h
>
> docs/devel/style.rst mandates:
>
> The "qemu/osdep.h" header contains preprocessor macros that affect
> the behavior of core system headers like <stdint.h>. It must be
> the first include so that core system headers included by external
> libraries get the preprocessor macros that QEMU depends on.
>
> Do not include "qemu/osdep.h" from header files since the .c file
> will have already included it.
>
> A few violations have crept in. Fix them.
>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> ---
> bsd-user/qemu.h | 1 -
> crypto/block-luks-priv.h | 1 -
> include/hw/cxl/cxl_host.h | 1 -
> include/hw/input/pl050.h | 1 -
> include/hw/tricore/triboard.h | 1 -
> include/qemu/userfaultfd.h | 1 -
> net/vmnet_int.h | 1 -
> qga/cutils.h | 1 -
> target/hexagon/hex_arch_types.h | 1 -
> target/hexagon/mmvec/macros.h | 1 -
> target/riscv/pmu.h | 1 -
> qga/cutils.c | 3 ++-
> 12 files changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/target/hexagon/hex_arch_types.h
> b/target/hexagon/hex_arch_types.h index 885f68f760..52a7f2b2f3 100644
> --- a/target/hexagon/hex_arch_types.h
> +++ b/target/hexagon/hex_arch_types.h
> @@ -18,7 +18,6 @@
> #ifndef HEXAGON_HEX_ARCH_TYPES_H
> #define HEXAGON_HEX_ARCH_TYPES_H
>
> -#include "qemu/osdep.h"
> #include "mmvec/mmvec.h"
> #include "qemu/int128.h"
Please change the copyright year in this file from "2019-2021" to "2019-2022".
Otherwise
Reviewed-by: Taylor Simpson <tsimp...@quicinc.com>
