On Fri, 9 Dec 2022 14:47:58 +0100 Markus Armbruster <arm...@redhat.com> wrote:
Hi Markus, One comment on the CXL ones. Others CXL related changes all looks fine to me. Thanks for cleaning these up. Jonathan > diff --git a/include/hw/cxl/cxl.h b/include/hw/cxl/cxl.h > index 38e0e271d5..5129557bee 100644 > --- a/include/hw/cxl/cxl.h > +++ b/include/hw/cxl/cxl.h > @@ -13,7 +13,6 @@ > > #include "qapi/qapi-types-machine.h" > #include "qapi/qapi-visit-machine.h" > -#include "hw/pci/pci_bridge.h" If we drop this, we probably want a forwards def of struct PXBDev I should probably be using the typedef in here as well rather than struct PXBDev * in CXLFixed Window so we'd need to deal with making that visible too. > #include "hw/pci/pci_host.h" > #include "cxl_pci.h" > #include "cxl_component.h" > #define CXL_VENDOR_ID 0x1e98
