On 9/12/22 11:55, Helge Deller wrote:
Add appropriate strace printf formats for various Linux syscalls.

Signed-off-by: Helge Deller <del...@gmx.de>
---
  linux-user/strace.list | 43 ++++++++++++++++++++++--------------------
  1 file changed, 23 insertions(+), 20 deletions(-)


  #ifdef TARGET_NR_poll
-{ TARGET_NR_poll, "poll" , NULL, NULL, NULL },
+{ TARGET_NR_poll, "poll" , "%s(%p,%d,%d)", NULL, NULL },

nfds_t is unsigned, so "%s(%p,%u,%d)"

  #endif
  #ifdef TARGET_NR_ppoll
-{ TARGET_NR_ppoll, "ppoll" , NULL, NULL, NULL },
+{ TARGET_NR_ppoll, "ppoll" , "%s(%p,%d,%p,%p)", NULL, NULL },

Ditto: "%s(%p,%u,%p,%p)"

  #ifdef TARGET_NR_recv
-{ TARGET_NR_recv, "recv" , NULL, NULL, NULL },
+{ TARGET_NR_recv, "recv" , "%s(%d,%p,%d,%u)", NULL, NULL },

It seems you switched the last argument: "%s(%d,%p,%u,%d)".

  #ifdef TARGET_NR_set_robust_list
-{ TARGET_NR_set_robust_list, "set_robust_list" , NULL, NULL, NULL },
+{ TARGET_NR_set_robust_list, "set_robust_list" , "%s(%p,%d)", NULL, NULL },

2nd arg is size_t, so "%s(%p,%u)".

Modulo the few unsigned formats:

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>


Reply via email to