Cédric Le Goater <c...@kaod.org> writes: > On 12/10/22 12:21, Markus Armbruster wrote: >> The next commit needs to include hw/ppc/pnv.h from >> hw/pci-host/pnv_phb.h. Avoid an inclusion loop. >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > > Reviewed-by: Cédric Le Goater <c...@kaod.org> > > Thanks, > > C. > > (one comment below) > >> --- >> hw/pci-host/pnv_phb.h | 1 + >> include/hw/pci-host/pnv_phb4.h | 3 ++- >> include/hw/ppc/pnv.h | 3 ++- >> hw/ppc/pnv_psi.c | 1 + >> 4 files changed, 6 insertions(+), 2 deletions(-) >> diff --git a/hw/pci-host/pnv_phb.h b/hw/pci-host/pnv_phb.h >> index 58ebd6dd0f..202de8796c 100644 >> --- a/hw/pci-host/pnv_phb.h >> +++ b/hw/pci-host/pnv_phb.h >> @@ -12,6 +12,7 @@ >> #include "hw/pci/pcie_host.h" >> #include "hw/pci/pcie_port.h" >> +#include "hw/ppc/pnv.h" > > Now that the chip definitions have been extrated in pnv_chip.h, I find > it curious that we need to include pnv.h since it should only contain > machine definitions. No big deal, I will take a look later. You did > the hard part and thanks for that.
I checked again, and it looks like an accident. I figure I put it there, then improved an earlier patch, which made it unneccessary. I'll take it out. Thanks!
