On Fri, 9 Dec 2022 at 11:17, Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > "target/arm/internals.h" is supposed to be *internal* to > target/arm/. hw/arm/virt.c includes it to get arm_pamax() > declaration. Move this declaration to "cpu.h" which can > be included out of target/arm/, and move the implementation > in machine.c which is always built with system emulation.
machine.c doesn't seem like the right place for this -- that file is purely concerned with migration. I don't know why we use 'machine.c' as our name for the file where the target CPU migration code lives, but that's fairly consistently what we name it across all architectures and we don't put other stuff in that file. I suppose it would be less confusing to rename all those files to migration.c... thanks -- PMM
