On 23 December 2011 11:40, Evgeny Voevodin <e.voevo...@samsung.com> wrote:
> +#define MCT_CFG_GET_PRESCALER(x) (x&0xFF)
> +#define MCT_CFG_GET_DIVIDER(x) (1<<(x>>8 & 7))
The macros in this file have the same bracket and spacing issues
as for the other patch.
> + case L0_TCON: case L1_TCON:
> + lt_i = ((offset&0xF00) - L0_TCNTB)/0x100;
More spaces in this kind of expression would be nice.
> +static SysBusDeviceInfo exynos4210_mct_info = {
> + .qdev.name = "exynos4210.mct",
> + .qdev.size = sizeof(struct Exynos4210MCTState),
> + .qdev.reset = exynos4210_mct_reset,
> + .qdev.vmsd = &VMState_Exynos4210MCTState,
> + .init = exynos4210_mct_init,
> + .qdev.props = (Property[]) {
> + DEFINE_PROP_END_OF_LIST(),
> + }
> +};
Unnecessary empty property list again.
Otherwise looks OK.
-- PMM
