On Sun, 27 Nov 2022 at 13:21, <tobias.roeh...@rwth-aachen.de> wrote: > > From: Tobias Röhmel <tobias.roeh...@rwth-aachen.de> > > The v8R PMSAv8 has a two-stage MPU translation process, but, unlike > VMSAv8, the stage 2 attributes are in the same format as the stage 1 > attributes (8-bit MAIR format). Rather than converting the MAIR > format to the format used for VMSA stage 2 (bits [5:2] of a VMSA > stage 2 descriptor) and then converting back to do the attribute > combination, allow combined_attrs_nofwb() to accept s2 attributes > that are already in the MAIR format. > > We move the assert() to combined_attrs_fwb(), because that function > really does require a VMSA stage 2 attribute format. (We will never > get there for v8R, because PMSAv8 does not implement FEAT_S2FWB.) > > Signed-off-by: Tobias Röhmel <tobias.roeh...@rwth-aachen.de>
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM