Re: [PATCH v3] hw/loongarch: Add cfi01 pflash device

[Philippe Mathieu-Daudé]

On 29/11/22 09:50, Xiaojuan Yang wrote:

Add cfi01 pflash device for LoongArch virt machine

Signed-off-by: Xiaojuan Yang <yangxiaoj...@loongson.cn>
---
  hw/loongarch/Kconfig        |  1 +
  hw/loongarch/acpi-build.c   | 18 +++++++++++
  hw/loongarch/virt.c         | 62 +++++++++++++++++++++++++++++++++++++
  include/hw/loongarch/virt.h |  5 +++
  4 files changed, 86 insertions(+)

+static void virt_flash_create(LoongArchMachineState *lams)
+{
+    DeviceState *dev = qdev_new(TYPE_PFLASH_CFI01);
+
+    qdev_prop_set_uint64(dev, "sector-length", VIRT_FLASH_SECTOR_SIZE);
+    qdev_prop_set_uint8(dev, "width", 4);
+    qdev_prop_set_uint8(dev, "device-width", 2);
+    qdev_prop_set_bit(dev, "big-endian", false);
+    qdev_prop_set_uint16(dev, "id0", 0x89);
+    qdev_prop_set_uint16(dev, "id1", 0x18);
+    qdev_prop_set_uint16(dev, "id2", 0x00);
+    qdev_prop_set_uint16(dev, "id3", 0x00);
+    qdev_prop_set_string(dev, "name", "virt.flash0");
+    object_property_add_child(OBJECT(lams), "virt.flash0", OBJECT(dev));
+    object_property_add_alias(OBJECT(lams), "pflash0",

s/flash0/flash/?

Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

Thanks for the updates!

+                              OBJECT(dev), "drive");
+
+    lams->flash = PFLASH_CFI01(dev);
+}