On 23/11/2022 11:06, BALATON Zoltan wrote:
Hello,
On Wed, 23 Nov 2022, Mark Cave-Ayland wrote:
This is something I've had lying around in the background for a while, and I
finally managed to get it in a state suitable for submission. The main
motivation was that I wanted to have a TCG operation reference that was
easily viewable online in a web browser.
Nice. Maybe including a link to the result could help review. Is this the right
link?
https://github.com/mcayland/qemu/blob/tcg-readme-rst/docs/devel/tcg.rst
Ah no, that's a different file - the one introduced by this patch can be found at
https://github.com/mcayland/qemu/blob/tcg-readme-rst/docs/devel/tcg-ops.rst.
The second paragraph refers to tcg/README which is this file and this patch moves it
so that sentence does not make much sense. Maybe it should be dropped and the only
remaining sentence from that paragraph added to the previous. In fact the last
sentence could also be added to avoid one sentence paragraphs and make the intro
section just one paragraph.
I can certainly fix up the link to tcg/README in the file referenced above, as that's
just the reverse of adding the link to the atomics documentation. I'll wait a bit for
any further comments before posting a v2.
I'd be inclined to leave other changes for now so that the conversion patch can be
merged sooner, and indeed it may be that this changes inspires someone to better
tidy-up and/or reorganise both these documents as there is certainly some overlap
between the two.
ATB,
Mark.
