On Tue, 15 Nov 2022 at 16:29, Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > Possible future cleanup, define JEP106_ID_ARM: > > $ git grep 0x43b > hw/intc/arm_gic.c:1671: *data = (s->revision << 16) | 0x43b; > hw/intc/gicv3_internal.h:743: return 0x43b; > hw/misc/armv7m_ras.c:26: *data = 0x43b;
I think that's probably not worthwhile, because the datasheet gives you the hex value of the ID register for the device, and if we hide that behind a #define then now to check that the value is right you need to go look at the #define line. Put another way, the important thing is "this register holds the value 0x43b", and it's just a point of information that that happens to correspond to a JEP-106 manufacturer ID code value. thanks -- PMM
