On 10/11/22 21:50, Stefan Hajnoczi wrote:
Preventing this class of bugs is important but QEMU is currently
frozen for the 7.2 release. I'm a little concerned about regressions
in a patch series that changes core device emulation code.
I'm waiting for Alex's MemTxRequesterType field addition in
MemTxAttrs [1] lands to rework my previous approach using
flatview_access_allowed() instead of access_with_adjusted_size()
[2]. I haven't looked at this series in detail, but since the
permission check is done on the Memory API layer, I might have
missed something in my previous intent (by using the FlatView
layer).
[1]
https://lore.kernel.org/qemu-devel/20221111182535.64844-2-alex.ben...@linaro.org/
[2]
https://lore.kernel.org/qemu-devel/20211215182421.418374-4-phi...@redhat.com/
I'll review the series on Monday and if anyone has strong opinions on
whether to merge this into 7.2, please say so. My thoughts are that
this should be merged in the 7.3 release cycle so there's time to work
out any issues.
Stefan
