Most of the changes are trivial. The bits test timeout has now been increased to 200 seconds in order to accommodate slower systems and fewer unnecessary failures. Removed of the reference to non-existent README file in docs. Some minor corrections in the doc file.
CC: Thomas Huth <th...@redhat.com> CC: Michael S. Tsirkin <m...@redhat.com> CC: qemu-triv...@nongnu.org Signed-off-by: Ani Sinha <a...@anisinha.ca> Reviewed-by: Thomas Huth <th...@redhat.com> --- docs/devel/acpi-bits.rst | 12 ++++-------- tests/avocado/acpi-bits.py | 8 ++++++-- 2 files changed, 10 insertions(+), 10 deletions(-) changes from v1: address Thomas' suggestions. changes from v2: more minor corrections in doc, tags added. changes from v3: raised timeout to 200 secs overriding the default avocado timeout of 120 secs. diff --git a/docs/devel/acpi-bits.rst b/docs/devel/acpi-bits.rst index c9564d871a..56e76338c3 100644 --- a/docs/devel/acpi-bits.rst +++ b/docs/devel/acpi-bits.rst @@ -16,11 +16,8 @@ end user. The other is that we have more control of what we wanted to test and how by directly using acpica interpreter on top of the bios on a running system. More details on the inspiration for developing biosbits and its real life uses can be found in [#a]_ and [#b]_. -This directory contains tests written in python using avocado framework that -exercises the QEMU bios components using biosbits and reports test failures. For QEMU, we maintain a fork of bios bits in gitlab along with all the -dependent submodules: -https://gitlab.com/qemu-project/biosbits-bits +dependent submodules here: https://gitlab.com/qemu-project/biosbits-bits This fork contains numerous fixes, a newer acpica and changes specific to running this avocado QEMU tests using bits. The author of this document is the sole maintainer of the QEMU fork of bios bits repo. @@ -38,10 +35,9 @@ Under ``tests/avocado/`` as the root we have: │ ├── bits-config │ │ └── bits-cfg.txt │ ├── bits-tests - │ │ ├── smbios.py2 - │ │ ├── testacpi.py2 - │ │ └── testcpuid.py2 - │ └── README + │ ├── smbios.py2 + │ ├── testacpi.py2 + │ └── testcpuid.py2 ├── acpi-bits.py * ``tests/avocado``: diff --git a/tests/avocado/acpi-bits.py b/tests/avocado/acpi-bits.py index 8745a58a76..a67d30d583 100644 --- a/tests/avocado/acpi-bits.py +++ b/tests/avocado/acpi-bits.py @@ -134,6 +134,9 @@ class AcpiBitsTest(QemuBaseTest): #pylint: disable=too-many-instance-attributes :avocado: tags=acpi """ + # in slower systems the test can take as long as 3 minutes to complete. + timeout = 210 + def __init__(self, *args, **kwargs): super().__init__(*args, **kwargs) self._vm = None @@ -385,8 +388,9 @@ def test_acpi_smbios_bits(self): self._vm.launch() # biosbits has been configured to run all the specified test suites # in batch mode and then automatically initiate a vm shutdown. - # sleep for maximum of one minute - max_sleep_time = time.monotonic() + 60 + # sleep for maximum of 200 seconds in order to accommodate + # even slower test setups. + max_sleep_time = time.monotonic() + 200 while self._vm.is_running() and time.monotonic() < max_sleep_time: time.sleep(1) -- 2.34.1
