On 11/12/22 04:25, Alex Bennée wrote:
+/*
+ * Bus masters which don't specify any attributes will get this which
+ * indicates none of the attributes can be used.
+ */
+#define MEMTXATTRS_UNSPECIFIED ((MemTxAttrs) \
+ { .requester_type = MTRT_UNSPECIFIED })
+
+/*
+ * Helper for setting a basic CPU sourced transaction, it expects a
+ * CPUState *
+ */
+#define MEMTXATTRS_CPU(cs) ((MemTxAttrs) \
+ {.requester_type = MTRT_CPU, \
+ .requester_id = cs->cpu_index})
+
+/*
+ * Helper for setting a basic PCI sourced transaction, it expects a
+ * PCIDevice *
*/
+#define MEMTXATTRS_PCI(dev) ((MemTxAttrs) \
+ {.requester_type = MTRT_PCI, \
+ .requester_id = pci_requester_id(dev)})
Any reason these second two shouldn't be inlines?
Anything with arguments gets better type checking that way, unless you need preprocessor
magic, which is not the case here.
Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
r~
