nyoro.ga...@gmail.com writes:
> From: Samker <nyoro.mar...@gmail.com>
>
> This is patch replaces WITH_QEMU_LOCK_GUARD() call with the
> QEMU_LOCK_GUARD()
You could extend this description as to why ".. because it extends the
scope of the lock to the whole function rather than the non-existent
block".
Otherwise:
Reviewed-by: Alex Bennée <alex.ben...@linaro.org>
>
> Signed-off-by: Samker <nyoro.mar...@gmail.com>
> ---
> softmmu/physmem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/softmmu/physmem.c b/softmmu/physmem.c
> index fb00596777..907491ae17 100644
> --- a/softmmu/physmem.c
> +++ b/softmmu/physmem.c
> @@ -3115,7 +3115,7 @@ void cpu_register_map_client(QEMUBH *bh)
> {
> MapClient *client = g_malloc(sizeof(*client));
>
> - WITH_QEMU_LOCK_GUARD(&map_client_list_lock);
> + QEMU_LOCK_GUARD(&map_client_list_lock);
> client->bh = bh;
> QLIST_INSERT_HEAD(&map_client_list, client, link);
> if (!qatomic_read(&bounce.in_use)) {
> @@ -3143,7 +3143,7 @@ void cpu_unregister_map_client(QEMUBH *bh)
> {
> MapClient *client;
>
> - WITH_QEMU_LOCK_GUARD(&map_client_list_lock);
> + QEMU_LOCK_GUARD(&map_client_list_lock);
> QLIST_FOREACH(client, &map_client_list, link) {
> if (client->bh == bh) {
> cpu_unregister_map_client_do(client);
--
Alex Bennée
